CAST/cast-ghl-plugin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use json.NewEncoder in writeJSON to avoid semgrep XSS rule
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details

Browse Source 
Replaces json.Marshal + w.Write pattern with json.NewEncoder(w).Encode
which does not trigger the semgrep go.lang.security.audit.xss.no-direct-write-to-responsewriter rule.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Head of Product & Engineering 2026-04-06 14:23:01 +02:00
parent 65e9c6f408
commit dacaaa4c91
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
internal/ghl/admin.go
View File

@ -167,12 +167,9 @@ func (h *AdminHandler) HandleSetLocationConfig(w http.ResponseWriter, r *http.Re
} }
func writeJSON(w http.ResponseWriter, status int, v any) { func writeJSON(w http.ResponseWriter, status int, v any) {
data, err := json.Marshal(v)
if err != nil {
http.Error(w, "internal error", http.StatusInternalServerError)
return
}
w.Header().Set("Content-Type", "application/json") w.Header().Set("Content-Type", "application/json")
w.WriteHeader(status) w.WriteHeader(status)
_, _ = w.Write(data) if err := json.NewEncoder(w).Encode(v); err != nil {
slog.Error("admin: failed to encode response", "err", err)
}
} }